Merged
Conversation
Varnish caches responses without varying on Origin, so whether CORS headers appear in cached responses depends on which request first populated the cache. Moving CORS to nginx ensures the headers are always present on every response regardless of cache state. Removes JAX-RS CORSFilter and Tomcat CorsFilter (web.xml /static/*); adds Access-Control-* headers and OPTIONS preflight (204) to nginx location / blocks in both docker-compose.yml and nginx.conf.template. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The cors-static.sh test was failing because Access-Control-Allow-Origin was only added to location / but not location ^~ /static/. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
namedgraph
added a commit
that referenced
this pull request
Apr 11, 2026
* Move CORS headers from Java filters to nginx Varnish caches responses without varying on Origin, so whether CORS headers appear in cached responses depends on which request first populated the cache. Moving CORS to nginx ensures the headers are always present on every response regardless of cache state. Removes JAX-RS CORSFilter and Tomcat CorsFilter (web.xml /static/*); adds Access-Control-* headers and OPTIONS preflight (204) to nginx location / blocks in both docker-compose.yml and nginx.conf.template. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add CORS header to /static/ nginx location blocks The cors-static.sh test was failing because Access-Control-Allow-Origin was only added to location / but not location ^~ /static/. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.